fix: trace filter policy #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the built-in trace filter would override the `default_value_action` which the user would supply. Also if the user supplies `default_value_action=drop`, the built-in filter would change it to `redact` for detected secret variables. We've updated the policy to not have such issues codetracer-python-recorder/resources/trace_filters/builtin_default.toml: codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: codetracer-python-recorder/src/trace_filter/engine.rs: codetracer-python-recorder/src/trace_filter/loader.rs: codetracer-python-recorder/src/trace_filter/model.rs: Signed-off-by: Tzanko Matev <[email protected]>
Coverage SummaryRust (lines)
Python (statements)
Generated automatically via |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the built-in trace filter would override the
default_value_actionwhich the user would supply.Also if the user supplies
default_value_action=drop, the built-in filter would change it toredactfor detected secret variables.We've updated the policy to not have such issues
codetracer-python-recorder/resources/trace_filters/builtin_default.toml: codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: codetracer-python-recorder/src/trace_filter/engine.rs: codetracer-python-recorder/src/trace_filter/loader.rs: codetracer-python-recorder/src/trace_filter/model.rs: